-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete TODO of replacing quatToXyzAngles with toEulerAngles #915
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I wanna do a quick test with it to make sure functionality is the same, but this todo has been here for a bit, good job
Mhmm! Just doing what I can, not the best at Java I took like, a single class on it. And I don't know much about the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very cool, hope to see you again in the future :3
Rust is more my thing but uh, I don't see much in the rust repo that is beginner lol |
we also have some rust in here if you want to refactor, its in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EulerOrder must be ZXY
Replaces
angleBuf = quatToXyzAngles(rot.unit(), angleBuf);
withEulerAngles eulerIntrinsic = rot.unit().toEulerAngles(EulerOrder.XYZ);
Since this also makes quatToXyzAngles now unused anywhere in the code, I decided to delete the unused function to save space.