Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent smoothing rollback #921

Merged
merged 2 commits into from
Jan 7, 2024
Merged

Prevent smoothing rollback #921

merged 2 commits into from
Jan 7, 2024

Conversation

Erimelowo
Copy link
Member

@Erimelowo Erimelowo commented Jan 7, 2024 •
edited
Loading

  • Increase max filtering values by a little bit because it's been bothering me for a while.
  • Prevent smoothing rollback:

before:
https://github.com/SlimeVR/SlimeVR-Server/assets/20461725/52efbd70-6bc5-4591-869d-14641393c044

after:
https://github.com/SlimeVR/SlimeVR-Server/assets/20461725/d7ea7e33-96bf-40dd-8ddf-89a8e6b7f13e

note: this is 1TPS, slowed down a lot. Actual smoothing wasn't that bad and this was barely noticeable.

ButterscotchV
ButterscotchV approved these changes Jan 7, 2024
View reviewed changes
Copy link
Member

@ButterscotchV ButterscotchV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kotlinified 🦊

@ImUrX
Copy link
Member

ImUrX commented Jan 7, 2024

you should upload the video directly to github, files in discord now have a limited time code in their link, so you will stop being able to watch the video

ImUrX
ImUrX reviewed Jan 7, 2024
View reviewed changes
Copy link
Member

@ImUrX ImUrX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a lot of else now, what happens if tracker filtering is None?

@Erimelowo
Copy link
Member Author

Erimelowo commented Jan 7, 2024 •
edited
Loading

I see a lot of else now, what happens if tracker filtering is None?

idea64_hvcBMvb3Ob

@Erimelowo Erimelowo merged commit ae1b60d into main Jan 7, 2024
7 checks passed
@Erimelowo Erimelowo deleted the better-smoothing branch January 7, 2024 04:46
@Erimelowo Erimelowo mentioned this pull request Mar 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ButterscotchV ButterscotchV ButterscotchV approved these changes

@ImUrX ImUrX ImUrX approved these changes

@Eirenliel Eirenliel Awaiting requested review from Eirenliel Eirenliel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Erimelowo @ImUrX @ButterscotchV