Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AUX trackers inconsistent tracker ID issue. #233

Merged
merged 5 commits into from
Mar 24, 2023

Conversation

ThreadOfFate
Copy link
Contributor

@ThreadOfFate ThreadOfFate commented Mar 14, 2023

This fixes a issue that would be seen as the server swapping the main and aux imu.
It also fixes a bug that swaps the calibration between main and aux imus resulting in worse tracking.

src/sensors/SensorManager.cpp Show resolved Hide resolved
src/sensors/SensorManager.cpp Show resolved Hide resolved
@ThreadOfFate ThreadOfFate marked this pull request as ready for review March 22, 2023 12:50
@0forks
Copy link
Contributor

0forks commented Mar 22, 2023

Maybe needs a PSA that recalibration will be needed for people who didn't wire addresses according to the docs (9250 or BMI), as it'll swap their sensor ids, even when only 1 IMU is present.

@ThreadOfFate
Copy link
Contributor Author

Maybe needs a PSA that recalibration will be needed for people who didn't wire addresses according to the docs (9250 or BMI), as it'll swap their sensor ids, even when only 1 IMU is present.

PSA sounds like a good idea.
We should cover
-that tracker assignment may switch in the server
-calibration may have swapped between sensors, before or because of this update and that it is recommend in general to recalibrate

@Eirenliel Eirenliel merged commit b3b5b75 into SlimeVR:main Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants