Added unenforced autoformatter #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for enforcing autoformatting across the codebase, I have come up with a clang-format style that I think is familiar.
If there are any really bad issues with it, please let me know and suggest some alternative settings. But I caution those giving feedback to not engage in a flame war or endless bikeshedding - its unlikely that we will ever all be satisfied with the exact format due to the lack of a historical precedent in C++.
You can upload this to this site to try it out.
Note that clang format doesn't make any stylistic choices concerning
snake_caseorcamelCase, or member variable naming conventions.Also note that this disables autoformatting of
lib, since that is all third-party code.