Minor firmware refactoring #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Eirenliel
commented
Jun 4, 2023
Eirenliel
commented
- Removed unused/incorrect code in BNO08X, fix BNO calibration commands
- Fix inspection sending redundand data
- Fix naming in sensor class
# Conflicts: # src/sensors/bmi160sensor.cpp # src/sensors/bno080sensor.cpp # src/sensors/sensor.h
TheDevMinerTV
requested changes
Jun 4, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Vyolex
reviewed
Jun 5, 2023
Vyolex
approved these changes
Jun 17, 2023
TheDevMinerTV
approved these changes
Jun 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.