-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glove #371
Conversation
Also save dynamic calibration periodically
Rename IMU_DESC_LIST to SENSOR_DESC_LIST Start work on many-imu glove support
Implement sending flex data, Minor refactoring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase to main and also move all of the unnecessary formatting commits into a different PR. It's impossible to review this PR otherwise.
Where is the discussion taking place for glove integration into SlimeVR? @Eirenliel thank you for sharing your work in this open tech context! From my experience, I'd recommend two things:
I have my first look at SlimeVR this week. Did you have a look at https://github.com/LucidVR/opengloves-driver already? Do you think those two communities could be joined? |
@adabru sorry for not replying earilier. The discussion is currently in private channels. It's out of scope how many sensors you would use, this PR adds support for multiplexing to have as many sensors as you might want. The actual skeleton computation is done on the server and it supports 1 to 3 sensors per finger. This PR is also not the place to discuss actual glove design |
Sorry but this needs to be reviewed as a whole, not as a history. A lot of changes were rethought during the development. If you can't review it, you can just not, it's fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try cleaning up my remaining complaints in a follow-up PR down the line
Pretty complex PR that changes how defines.h works, so it needs changes from all firmware tools @ButterscotchV @loucass003
Changes
Defines changes
DIRECT_WIRE(scl, sda)
- I2C on GPIOPCA_WIRE(scl, sda, pca_addr, pca_channel)
- I2C on PCA9546A I2C expanderDIRECT_PIN(pin)
- INT pin on GPIOMCP_PIN(pin)
- INT pin on MCP23X17 GPIO extenderNO_PIN
- INT pin not usedTest plan
There are a lot of changes, so we should do some testing before it's merged. I did some, but we need help with testing with other IMUs
I'm once again asking for help with testing!
Other important stuff:
WHY, EIREN??
Now we can do THIS in mainline firmware!

Future stuff
Currently with 10 BNO sensors I get only 10 TPS on all of them, even when not all of them move. I think it can be optimized, and maybe we should start using additional cores where available. But that's out of scope right now, the goal was to support more sensors, not to make them work amazingly.