Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable self-contained deployment and trimming for GeniusService #101

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

Smalls1652
Copy link
Owner

Description

This PR is disabling the self-contained deployment and trimming options for GeniusService. As it stands right now, with EFCore and it's CosmosDB provider, I can't fully guarantee that trimming is 100% not breaking anything. I'm going to err on the side of caution for now.

Good news is that it makes the container image smaller.

Type of change

  • 🌟 New feature
  • 💪 Enhancement
  • 🪳 Bug fix
  • 🧹 Maintenance

Related issues

  • None

@Smalls1652 Smalls1652 added the enhancement New feature or update to an existing feature label Apr 6, 2024
@Smalls1652 Smalls1652 self-assigned this Apr 6, 2024
@Smalls1652 Smalls1652 merged commit 4e6ae83 into main Apr 6, 2024
6 checks passed
@Smalls1652 Smalls1652 deleted the update/geniusservice/remove-self-contained branch April 6, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or update to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant