-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A big collection of updates #40
Merged
Smalls1652
merged 13 commits into
main
from
update/oops/i-included-too-much-in-this-branch
Jan 3, 2024
Merged
A big collection of updates #40
Smalls1652
merged 13 commits into
main
from
update/oops/i-included-too-much-in-this-branch
Jan 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implements activity tracing - Added code docs - Implemented IDisposable - Added using statement for created HttpClients
- Implements activity tracing - Added code docs - Implemented IDisposable - Added using statement for created HttpClients
- Implements activity tracing - Added code docs - Implemented IDisposable - Added using statement for created HttpClients
- Implements new extension methods for creating activities - Implemented passing the activity ID to dependent services
Smalls1652
added
documentation
Improvements or additions to documentation
enhancement
New feature or update to an existing feature
labels
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or update to an existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR exploded in size and contains quite a bit of changes (Some of the changes were too related). Here's what's been changed:
CommandMetricsMeterProviderBuilderExtensions
into a generic class for OpenTelemetry extension methods. It includes a new extension method for adding the core MuzakBot sources to the trace provider.OdesliService
,ItunesApiService
,MusicBrainzService
, andShareMusicCommandModule
respectively.Activity
objects fromActivitySource
objects.OdesliService
,ItunesApiService
, andMusicBrainzService
.HttpClient
usage inOdesliService
,ItunesApiService
, andMusicBrainzService
.using
statement when theHttpClient
is initialized so it's properly disposed of at the end of execution.Activity
object to dependent services/methods used inShareMusicCommandModule
.Related issues
None