Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lyrics analyzer rate limit #64

Merged
merged 6 commits into from
Jan 16, 2024
Merged

Conversation

Smalls1652
Copy link
Owner

Description

This PR fixes a bug with how rate limits are tracked for the lyrics analyzer command.

Every now and then, the user ID property would not be serialized correctly as a ulong type. Seems like it was on the CosmosDB side and not directly in the code? What I ended up doing to fix it was changing the type from ulong to string.

In addition, I added an intialization step for the CosmosDbService to ensure that the database and containers exist and, if they don't, to create them at startup. Needed this for locally testing the changes.

Type of change

  • 🌟 New feature
  • 💪 Enhancement
  • 🪳 Bug fix
  • 🧹 Maintenance

Related issues

@Smalls1652 Smalls1652 self-assigned this Jan 16, 2024
@Smalls1652 Smalls1652 added bug Something isn't working bug fix Fixes a bug labels Jan 16, 2024
@Smalls1652 Smalls1652 merged commit 2e9ebce into main Jan 16, 2024
2 checks passed
@Smalls1652 Smalls1652 deleted the bug-fix/lyrics-analyzer/rate-limit branch January 16, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fixes a bug bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug report]: Lyrics analyzer rate limit is broken
1 participant