Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to @oclif/core + fix GHA Workflows #281

Merged
merged 10 commits into from
Apr 3, 2023
Merged

Upgrade to @oclif/core + fix GHA Workflows #281

merged 10 commits into from
Apr 3, 2023

Conversation

CalemRoelofsSB
Copy link
Contributor

@CalemRoelofsSB CalemRoelofsSB commented Feb 15, 2023 •
edited
Loading

This PR:

  • Migrates from legacy @oclif/command package to newest @oclif/core
  • Refactors codebase to work with newest @oclif/core version
  • Removes unused GHA workflows and adds a proper release workflow
  • Bumps all other package that can be to newest versions
  • Drops support for deprecated Node version 12.x and 14.x

@CalemRoelofsSB CalemRoelofsSB added the enhancement New feature or request label Feb 15, 2023
@CalemRoelofsSB CalemRoelofsSB marked this pull request as draft February 15, 2023 11:56
@CalemRoelofsSB
Copy link
Contributor Author

Node 14 support is broken in newest version of @oclif/core as noted here, so moving this PR to draft until it's resolved.
oclif/core#630

barryadk
barryadk previously approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@barryadk barryadk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

MateuszPol
MateuszPol previously approved these changes Feb 27, 2023
View reviewed changes
@CalemRoelofsSB CalemRoelofsSB mentioned this pull request Mar 30, 2023
Merged
@CalemRoelofsSB CalemRoelofsSB dismissed stale reviews from MateuszPol and barryadk via ed74be4 March 31, 2023 14:14
@CalemRoelofsSB CalemRoelofsSB marked this pull request as ready for review March 31, 2023 14:17
@CalemRoelofsSB CalemRoelofsSB merged commit cb18971 into main Apr 3, 2023
@CalemRoelofsSB CalemRoelofsSB deleted the ci/upgrade-packagesand-repo-housekeeping branch April 3, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barryadk barryadk barryadk approved these changes

@lukaszantkowiak lukaszantkowiak Awaiting requested review from lukaszantkowiak

@MateuszPol MateuszPol Awaiting requested review from MateuszPol

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CalemRoelofsSB @MateuszPol @barryadk