Skip to content

Fixed search button in mobile and SDL app. SDL CarWindow menu is not scrollable #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fixed search button in mobile and SDL app. SDL CarWindow menu is not scrollable #21

wants to merge 6 commits into from

Conversation

FrankElias77
Copy link

Issue #20

@FrankElias77 FrankElias77 added the bug Something isn't working label Apr 20, 2022
@FrankElias77 FrankElias77 self-assigned this Apr 20, 2022
@FrankElias77 FrankElias77 marked this pull request as ready for review April 20, 2022 16:00
@joeljfischer joeljfischer self-requested a review April 21, 2022 14:44
joeljfischer
joeljfischer suggested changes Apr 21, 2022
View reviewed changes
joeljfischer
joeljfischer suggested changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@joeljfischer joeljfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Search results seem to show Chicago area results (SDL, in-app seems to work)
  2. "Find Restaurants near me" show results near Chicago (SDL).
  3. There is no in-app dot for current location (note this was after I connected / disconnected from SDL)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@joeljfischer joeljfischer joeljfischer requested changes

Reviewers whose approvals may not affect merge requirements
Assignees

@FrankElias77 FrankElias77

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrankElias77 @joeljfischer