Skip to content

Changed Asset images to System images #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

FrankElias77
Copy link
Contributor

@FrankElias77 FrankElias77 commented May 27, 2021

Fixes #17

Summary

Start the app with the current screen instead of the intro screen

Core Tests

Tested on Manticore, generic_hmi, SYNC 3.0

@FrankElias77 FrankElias77 changed the title Change Asset images to System images Changed Asset images to System images May 27, 2021
@FrankElias77 FrankElias77 marked this pull request as ready for review May 27, 2021 16:42
@joeljfischer joeljfischer deleted the feature/issue-17-replace-internal-images-with-ios-system-images branch June 21, 2021 17:49
@joeljfischer joeljfischer restored the feature/issue-17-replace-internal-images-with-ios-system-images branch June 25, 2021 13:32
@joeljfischer joeljfischer reopened this Jun 25, 2021
Frank Elias added 2 commits July 1, 2021 15:41
artworkFromConditionImage
@joeljfischer joeljfischer changed the base branch from master to develop July 2, 2021 14:05
…with-ios-system-images

# Conflicts:
#	SmartDeviceLinkService.m
@joeljfischer
Copy link
Contributor

None of the above resolved comments were done. Did you forget to push?

artworkFromConditionImage update
Copy link
Contributor

@joeljfischer joeljfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more items

Frank Elias added 3 commits July 27, 2021 11:33
Updated the build deployment target for storyboard to match the project based on warning in xcode.
@joeljfischer joeljfischer merged commit b30cc70 into develop Aug 19, 2021
@joeljfischer joeljfischer deleted the feature/issue-17-replace-internal-images-with-ios-system-images branch August 19, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace internal images with iOS system images
2 participants