-
Notifications
You must be signed in to change notification settings - Fork 4
Changed Asset images to System images #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
joeljfischer
merged 16 commits into
develop
from
feature/issue-17-replace-internal-images-with-ios-system-images
Aug 19, 2021
Merged
Changed Asset images to System images #21
joeljfischer
merged 16 commits into
develop
from
feature/issue-17-replace-internal-images-with-ios-system-images
Aug 19, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeljfischer
suggested changes
Jun 4, 2021
joeljfischer
suggested changes
Jun 28, 2021
joeljfischer
suggested changes
Jul 1, 2021
artworkFromConditionImage
…with-ios-system-images # Conflicts: # SmartDeviceLinkService.m
joeljfischer
suggested changes
Jul 2, 2021
None of the above resolved comments were done. Did you forget to push? |
artworkFromConditionImage update
joeljfischer
suggested changes
Jul 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few more items
joeljfischer
suggested changes
Jul 26, 2021
Updated the build deployment target for storyboard to match the project based on warning in xcode.
joeljfischer
suggested changes
Jul 28, 2021
joeljfischer
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17
Summary
Start the app with the current screen instead of the intro screen
Core Tests
Tested on Manticore, generic_hmi, SYNC 3.0