Implement relative date formatter for hourly choice sets #23
Conversation
There was a problem hiding this comment.
After seeing it, I don't think that this change looks right. There are a number of issues:
(1) When going to hourly list, it starts from 5 hours ago, which it shouldn't.
(2) It's harder to understand what time things are happening.
To fix this:
(1) It definitely needs to start at the next hour, not 5 hours in the past. This is weird because I don't actually think the data does start back then. I think it's an implementation bug.
(2) The relative formatting should only happen for the first or first and second choices.
(3) The hourly formatting would need to apply with "tomorrow" information.
(4) It's probably better to go to every 2 hours instead of every hour.
(5) This should apply to date formatting too, for the first 2 (today, tomorrow) but not the ones after that.
This is too much work for something that doesn't really matter, so I think it's probably better to drop this PR for now.
| NSRelativeDateTimeFormatter *hourlyDateFormatShow = [[NSRelativeDateTimeFormatter alloc] init]; | ||
| [hourlyDateFormatShow setUnitsStyle:NSRelativeDateTimeFormatterUnitsStyleShort]; |
There was a problem hiding this comment.
Get rid of the warnings by moving this to iOS 13.0+
Fixes #22