feat: add help text when entering a redirect URI #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d28b34f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rossiam
force-pushed
the
redirect-uri-help-text
branch
from
0106956 to
03f1a00
Compare
Sitlintac
approved these changes
May 23, 2023
| export const oauthAppScopeDef = checkboxDef<string>('Scopes', availableScopes, { | ||
| helpText: 'More information on OAuth 2 Scopes can be found at:\n' + | ||
| ' https://www.oauth.com/oauth2-servers/scope/\n\n' + | ||
| 'To find out which scopes you need for the application, see documentation for the individual endpoints you will use in your app:\n' + |
There was a problem hiding this comment.
Consider using "determine" instead of "find out".
There was a problem hiding this comment.
Definitely! Fixed.
rossiam
force-pushed
the
redirect-uri-help-text
branch
from
03f1a00 to
d28b34f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for help text on inputs in the new
item-inputmodule.Primary changes:
helpTexttoaskForStringtoaskForOptionalStringfunctions which adds " (? for help)" text to prompt and displays value ofhelpTextif the user enters "?"helpTexttoarrayDef,checkboxDefandobjectDefhelpTextfor these functions in several placesSecondary cleanup:
askForStringtoaskForOptionalStringand updated calls to it (now matches naming convention used foroptionalStringDef)askForRequiredStringtoaskForStringand updated calls to it (now matches naming convention used forstringDef)askForOptionalStringandaskForStringinto a function called by bothvalidateargument intooptionsargument for bothaskForOptionalStringandaskForStringvalidateargument intooptionsargument for bothoptionalStringDefandstringDefAskForStringOptionstype foroptionsargument toaskForStringtoaskForOptionalStringAskForStringOptionsas base forStringDefOptionstype foroptionalStringDefandstringDeffunctionsChecklist
npm run lintproduces no warnings/errors)