added redeemed text, compressed images #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rosieprom
commented
Dec 4, 2019
rosieprom
commented
- Added redeemed text for the ticket
- Compressed the background image and logo.
- Background image: 2.98 KB
- Logo: 290.80 KB
- used https://kraken.io/web-interface to compress but let me know if you got any ideas on image compression :)
|
oh also made the corners curved a bit more. |
JamesANZ
reviewed
Dec 4, 2019
examples/UEFA/UEFA.en.shtml
Outdated
| @@ -113,6 +113,8 @@ class Token { | |||
| redeemedMessage = "(Redeemed)" | |||
| } else if(this.props.redeemed === "0") { | |||
| redeemedMessage = "(Not redeemed)" | |||
| } else { | |||
| redeemedMessage = "Redeem Error" | |||
There was a problem hiding this comment.
@developerpeachy can we have it that it simply displays nothing if not redeemed or there is an error?
JamesANZ
approved these changes
Dec 4, 2019
@developerpeachy Have you tried ImageOptim for PNG and ShrinkIt for PDF? |
|
@hboon no, I can give this a go. The file types i have are .png and .svg though. |
|
Closes #290 |
SmartLayer
pushed a commit
that referenced
this pull request
Jun 30, 2023
added redeemed text, compressed images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.