-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added redeemed text, compressed images #291
Conversation
rosieprom
commented
Dec 4, 2019
- Added redeemed text for the ticket
- Compressed the background image and logo.
- Background image: 2.98 KB
- Logo: 290.80 KB
- used https://kraken.io/web-interface to compress but let me know if you got any ideas on image compression :)
oh also made the corners curved a bit more. |
examples/UEFA/UEFA.en.shtml
Outdated
@@ -113,6 +113,8 @@ class Token { | |||
redeemedMessage = "(Redeemed)" | |||
} else if(this.props.redeemed === "0") { | |||
redeemedMessage = "(Not redeemed)" | |||
} else { | |||
redeemedMessage = "Redeem Error" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@developerpeachy can we have it that it simply displays nothing if not redeemed or there is an error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@developerpeachy thanks for this but please address comment above before merging. Also, in future it is best to make PRs atomic e.g. added redeemed text and a separate PR for the images
@developerpeachy Have you tried ImageOptim for PNG and ShrinkIt for PDF? |
@hboon no, I can give this a go. The file types i have are .png and .svg though. |
Closes #290 |
added redeemed text, compressed images