Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added redeemed text, compressed images #291

Merged
merged 3 commits into from
Dec 10, 2019
Merged

Conversation

rosieprom
Copy link
Contributor

IMG_2667

  • Added redeemed text for the ticket
  • Compressed the background image and logo.
  • Background image: 2.98 KB
  • Logo: 290.80 KB
  • used https://kraken.io/web-interface to compress but let me know if you got any ideas on image compression :)

@rosieprom
Copy link
Contributor Author

oh also made the corners curved a bit more.

@@ -113,6 +113,8 @@ class Token {
redeemedMessage = "(Redeemed)"
} else if(this.props.redeemed === "0") {
redeemedMessage = "(Not redeemed)"
} else {
redeemedMessage = "Redeem Error"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@developerpeachy can we have it that it simply displays nothing if not redeemed or there is an error?

Copy link
Contributor

@bitcoinwarrior1 bitcoinwarrior1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@developerpeachy thanks for this but please address comment above before merging. Also, in future it is best to make PRs atomic e.g. added redeemed text and a separate PR for the images

@hboon
Copy link
Member

hboon commented Dec 4, 2019

@developerpeachy Have you tried ImageOptim for PNG and ShrinkIt for PDF?

@rosieprom
Copy link
Contributor Author

@hboon no, I can give this a go. The file types i have are .png and .svg though.

@bitcoinwarrior1 bitcoinwarrior1 merged commit 0ed4344 into master Dec 10, 2019
@bitcoinwarrior1 bitcoinwarrior1 deleted the UEFA-redeem-item branch December 10, 2019 01:03
@bitcoinwarrior1
Copy link
Contributor

Closes #290

SmartLayer pushed a commit that referenced this pull request Jun 30, 2023
added redeemed text, compressed images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants