Skip to content

update web3 data changed callback #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2020
Merged

update web3 data changed callback #394

merged 1 commit into from
Oct 12, 2020

Conversation

JamesANZ
Copy link
Contributor

@JamesANZ JamesANZ requested a review from hboon October 10, 2020 23:48
hboon
hboon requested changes Oct 11, 2020
View reviewed changes
Copy link
Member

@hboon hboon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs changes like this https://github.com/AlphaWallet/alpha-wallet-ios/pull/2161/files#diff-21eeed1f14eca84e42fe18b15a229ae9L67

@JamesANZ JamesANZ force-pushed the update-callback-to-token-data branch from bb9fbad to 457c698 Compare October 12, 2020 05:03
@JamesANZ
Copy link
Contributor Author

Also needs changes like this https://github.com/AlphaWallet/alpha-wallet-ios/pull/2161/files#diff-21eeed1f14eca84e42fe18b15a229ae9L67

Thanks @hboon, updated.

hboon
hboon requested changes Oct 12, 2020
View reviewed changes
Copy link
Member

@hboon hboon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more. I just did a quick pass. See if they are right.

@JamesANZ JamesANZ force-pushed the update-callback-to-token-data branch from 457c698 to 40cab86 Compare October 12, 2020 05:23
@JamesANZ
Copy link
Contributor Author

@hboon sorry, should be good now!

@hboon
Copy link
Member

hboon commented Oct 12, 2020

Good to merge. Thanks!

@JamesANZ JamesANZ merged commit 656935f into master Oct 12, 2020
@JamesANZ JamesANZ deleted the update-callback-to-token-data branch October 12, 2020 05:59
SmartLayer pushed a commit that referenced this pull request Jun 30, 2023
@JamesANZ
Merge pull request #394 from AlphaWallet/update-callback-to-token-data
9c5b3cc 
update web3 data changed callback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hboon hboon hboon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JamesANZ @hboon