Update gems #157
Update gems #157
Conversation
... to 4.0 for ruby >=2.5.0
…uby_version >= 2.5.0
rack 2.2.2 sprockets 4.0.0 rufus 3.6.0 and thor 1.0.1 changed thin to 1.7.2 (which is used already anyhow)
There was a problem hiding this comment.
@rompic I tested your pull request and it worked fine for me. I am still checking the updates in each gem, but you rationale for the update looks good.
Great work investigating the memory leaks. I haven't tried it, but I think we should update the gems first, and then check if there are memory leaks with the newer gems.
I went through the commit history to prepare the 1.2.0 and generate the commit changelogs. And every release had one or more commits to update gems, similar to yours. And it's been +2 years since the previous release, so about time to update our dependencies 👍
Let me know if you are OK with that, or if you would like to update/change this PR. If you are OK, you can mark as ready for review. I will do one more round of testing, and then we can merge it.
Thanks!
|
thanks for looking into it. |
|
Excellent! Thanks @rompic ! |
already based on #156