Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use old-style hash syntax to enable compatibility with ruby 1.8.7 #52

Merged
merged 1 commit into from
Apr 6, 2017

Conversation

teancom
Copy link
Contributor

@teancom teancom commented Mar 13, 2017

Some of us are still stuck on Centos 6.x with ruby 1.8.7. Yes, it sucks. Yes, we're trying to move. In the meantime, this allows us to use smashing with dashing-icinga2.

Thank you!

@terraboops
Copy link

Yeah, cool. Generally I am against moving backwards, but since I don't see how this makes future contributions harder and adds value for backwards compatibility - awesome.

Thanks for contributing!

@terraboops terraboops merged commit 08a11d0 into Smashing:master Apr 6, 2017
@webmaster128
Copy link

I think we should define an officially supported minimum Ruby version for each major release of smashing, because if we want to support Ruby 1.8.7, we cannot upgrade dependencies like e.g. sprockets, which requires Ruby 1.9.3 starting with sprockets version 3. It would be very unfortunate if smashing breaks for users because people upgrading gems miss such a patch PR.

@kinow kinow added this to the 1.1.0 milestone May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants