Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown attributes values not displayed in adminhtml #1189

Closed
romainruaud opened this issue Nov 19, 2018 · 0 comments
Closed

Dropdown attributes values not displayed in adminhtml #1189

romainruaud opened this issue Nov 19, 2018 · 0 comments
Assignees
@rbayet
Labels
bug

Comments

@romainruaud
Copy link
Collaborator

According to this commit : magento/magento2@2f057f7#diff-5ab37ddfe3a4d9011d97bb9f7e4375bf

The JS part responsible of attribute editing in Back-Office have been completely reworked by Magento.

This seems to cause attributes values not being displayed in adminhtml according to #1169

The proposed fix is not what we should achieve.

Instead we should :

  • comply with Magento rework.
  • ensure our enhancements in this functional zone remains intacts (it was to set varchar attributes filterable in search and navigation, see ea17c42).
  • I'm not really sure we should wonder about BC here, since the Magento rework is quite old and was introduced in 2.1.x
rbayet added a commit to rbayet/elasticsuite that referenced this issue Nov 19, 2018
@rbayet
Fixes Smile-SA#1189 Missing dropdown attributes values
5ecaa65 
Part 1: when Magento_Swatches/Smile_ElasticsuiteSwatches are enabled
rbayet added a commit to rbayet/elasticsuite that referenced this issue Nov 20, 2018
@rbayet
Fixes Smile-SA#1189 Missing dropdown attributes values(1/2)
4dea7c3 
Part 1: when Magento_Swatches/Smile_ElasticsuiteSwatches are enabled
rbayet added a commit to rbayet/elasticsuite that referenced this issue Nov 20, 2018
@rbayet
Fixes Smile-SA#1189 Missing dropdown attributes values(2/2)
7308e26 
Part 2: when Magento_Swatches/Smile_ElasticsuiteSwatches are disabled
Note: possible non-working native code ?
rbayet added a commit to rbayet/elasticsuite that referenced this issue Nov 20, 2018
@rbayet
Fixes Smile-SA#1189 Missing dropdown attributes values(1/2)
036ca0b 
Part 1: when Magento_Swatches/Smile_ElasticsuiteSwatches are enabled
Modules' declared dependencies are not enough to make sure the following order of layout files is achieved :
- Magento_Catalog
- Smile_ElasticsuiteCatalog
- Magento_Swatches
- Smile_ElasticsuiteSwatches
which would be the only order not requiring Smile_ElasticsuiteSwatches to re-declare
the setTemplate on attribute_edit_js
rbayet added a commit to rbayet/elasticsuite that referenced this issue Nov 20, 2018
@rbayet
Fixes Smile-SA#1189 Missing dropdown attributes values(2/2)
ee6cd81 
Part 2: when Magento_Swatches/Smile_ElasticsuiteSwatches are disabled
Note: possible non-working native code ?
rbayet added a commit to rbayet/elasticsuite that referenced this issue Nov 20, 2018
@rbayet
Fixes Smile-SA#1189 Missing dropdown attributes values(2/2)
aab21b7 
Part 2: when Magento_Swatches/Smile_ElasticsuiteSwatches are disabled
Note: possible non-working native code ?
romainruaud added a commit that referenced this issue Nov 21, 2018
@romainruaud
Merge pull request #1191 from rbayet/fix_1189_admin_dropdown_attr_val…
dddb039 
…ues_not_displayed

Fixes #1189 Missing dropdown attributes values
@rbayet rbayet mentioned this issue Nov 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rbayet rbayet

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rbayet @romainruaud