-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When a virtual category root is deleted, all products are shown #1937
Comments
Hello @amenk, Could you please provide more details for your test case, maybe smth like a real detail example. Because from the current description it looks like a little bit blurry and not quite understood what you want to test and what you want to get or expect to see at the end result. Best regards |
@vahonc updated |
Hi @amenk, Well, now it is clearer what you have now and what you expect at the end.
and so on... This will really help us to more accurately understand your case and determine where we have a problem and offer you a solution as soon as possible. Best regards |
@vahonc edited |
…n deleted virtual category
Hello @amenk, Sorry for the long silence on your problem. I have added a PR with a solution that should fix it. Could you please check it out or share your thoughts on this. Best regards, |
This issue was waiting update from the author for too long. |
This issue was waiting update from the author for too long. |
Hello @amenk unfortunately, we will not fix this particular case. To be clear, "virtual root category", with the actual behavior, is just a short-hand to creating a condition on "category = X" on the rule section. It was supposed to do more (automatically generate category filters according to the childrens of the root category, etc....) but that's still not the case right now. That being said, the "virtual root category" condition is added to the virtual rule query as a pre-filter, meaning that :
The same does apply in your case, except you only have a virtual root category, meaning that if you delete your root category, you end up with a query having no filter clause at all : this will fetch the entire catalog. So despite being quite of an edge case, it's in our opinion working as intended. Regards |
fair enough, makes sense. |
You're welcome, I close the issue then |
We had the problem again and were wondering if there is SQL query to identify such problems, so we could at least add it to the monitoring. |
This is just for the record, don't really expect a fix, but want to have it documented in case others stumble upon it.
Preconditions
In the backend it shows "entity with ID doesn't exist"
In the virtual category (another their parents, because of is_anchor) now unrelated products appear
Expected Result
The virtual category V is empty, because it links to an invalid category
Current Result
The virtual category V and also the parent categories seem to include all products from the catalog.
The text was updated successfully, but these errors were encountered: