Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of jQuery 3 deprecated event shorthands #2765

Closed
MartynasKasp opened this issue Oct 26, 2022 · 2 comments
Closed

Use of jQuery 3 deprecated event shorthands #2765

MartynasKasp opened this issue Oct 26, 2022 · 2 comments
Assignees

Comments

@MartynasKasp
Copy link

MartynasKasp commented Oct 26, 2022

Preconditions

jQuery version: 3.6.0
Magento Version: 2.4.5-p1 OpenSource
ElasticSuite Version: latest (2.10.12.1)
Environment: Developer
Third party modules: -

Steps to reproduce

Upgraded Magento version to 2.4.5-p1 which uses jQuery 3.6.0 (this version has some major changes and deprecations comparing to 1.12.4 which was used for previous Magento versions).
Opened category page on the storefront and got info log in console.

Expected result

I expect this package not to use deprecated jQuery functions (therefore no errors in console).

Actual result

image

This is not the only deprecated jQuery function still in use for this project! There are a lot more like: bind, isArray, focus, etc.

jQuery Migrate plugin warning messages doc: https://github.com/jquery/jquery-migrate/blob/main/warnings.md

@romainruaud
Copy link
Collaborator

Thank for signaling this @MartynasKasp

That's something we'll fix in the future.

Regards

@smartexcan
Copy link

Just wanted to add on to this that jquery.touch-punch should also be updated. Though the main repo isnt being updated anymore, there is a maintained fork available
https://github.com/RWAP/jquery-ui-touch-punch

vahonc added a commit to vahonc/elasticsuite that referenced this issue Dec 15, 2022
vahonc added a commit to vahonc/elasticsuite that referenced this issue Dec 17, 2022
vahonc added a commit to vahonc/elasticsuite that referenced this issue Dec 20, 2022
vahonc added a commit to vahonc/elasticsuite that referenced this issue Dec 20, 2022
vahonc added a commit to vahonc/elasticsuite that referenced this issue Dec 20, 2022
vahonc added a commit to vahonc/elasticsuite that referenced this issue Dec 20, 2022
romainruaud added a commit to romainruaud/elasticsuite that referenced this issue Jan 24, 2023
romainruaud added a commit that referenced this issue Jan 24, 2023
Fix #2765 by replacing bind event on jquery touchpunch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants