#2733, Fix indexing of child products SKUs #2753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vahonc
force-pushed
the
2733-indexing-child-products-skus-2.10-fix
branch
from
874c650
to
ae476cf
Compare
vahonc
changed the title
|
Hi @vahonc there is still a PHPMD issue. It's due to the usage of "else" which is not recommended, but in this case, I think we can ignore the warning by added a PHPMD statement. You can find how to do it by searching for "ElseExpression" in the source code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably need to add text translation for a new setting in Magento BO, at least for French.