Add Support for OpenSearch Settings in Setup ConfigOptions List #3327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using the ternary phpcs bugs requiring a single space, by adding only one space the lines goes way beyond the allowed size, by adding a breakline warns that a space was required, but...
romainruaud
reviewed
Jul 18, 2024
romainruaud
reviewed
Jul 18, 2024
romainruaud
reviewed
Jul 18, 2024
romainruaud
previously requested changes
Jul 18, 2024
|
@macoaure can you please update your PR ? Regards |
|
hey @romainruaud sorry for my delay, i have fixed the coding standard. |
rbayet
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for configuring OpenSearch settings within the Setup ConfigOptions list in ElasticSuite. By adding this feature, users can now specify OpenSearch-specific configurations, enhancing the flexibility and compatibility of ElasticSuite with OpenSearch.