Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Virtual Category] Fix php8.3 deprecation when root category don't ha… #3336

Merged
merged 1 commit into from
Jul 24, 2024
Merged

[Virtual Category] Fix php8.3 deprecation when root category don't ha… #3336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/module-elasticsuite-virtual-category/Model/Rule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ private function buildCategorySearchQuery($category, $excludedCategories = []):
private function getVirtualRootCategory(CategoryInterface $category): ?CategoryInterface
{
$storeId = $this->getStoreId();
$rootCategory = $this->categoryFactory->create()->setStoreId($storeId);
$rootCategory = null;

if ($category->getVirtualCategoryRoot() !== null && !empty($category->getVirtualCategoryRoot())) {
$rootCategoryId = $category->getVirtualCategoryRoot();
Expand Down Expand Up @@ -433,7 +433,10 @@ private function getVirtualCategoryQuery(
// - - Category C (virtual with category B as root)
// When you compute the rule of the category A you do not need to compute the rule of the category C
// as all the product will be there.
if ($rootCategory && array_intersect(explode('/', $rootCategory->getPath()), $excludedCategories)) {
if ($rootCategory
&& $rootCategory->getPath()
&& array_intersect(explode('/', (string) $rootCategory->getPath()), $excludedCategories)
) {
return null;
}

Expand Down
Loading