Enable store selection on map using markers #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is our 'simple' answer to an identified UX default.
Referencing this issue : (#15)
When choosing a store in shipping step, we can't select it using markers on map. It appears to be quite confusing for users, because details are displayed but retailerId not set as current shop.
A solution could be to set
this.currentRetailerId(markerData.id);on click on marker.Smile_StoreDelivery/js/view/checkout/shipping/store-mapextendsSmile_StoreLocator/js/retailer/store-mapwhich extendsSmile_Map/js/mapwhich defines loadMarkers() method.Considering
smile-mapis replaced in our custom module'srequirejs-configin order to develop extra functionnalities about markers and stock, we were forced to redeclare loadMarkers() here...It would be nice to hear your thoughts on this.