Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX fallback to default Magento search if ES server is down (Issue #47) #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mobilizer
Copy link

@mobilizer mobilizer commented Oct 27, 2016

Current implementation fails with an error if the Elasticsearch server is down, unavailable or catalog/search/engine configuration is set to "MySQL".

Call to undefined method Mage_Catalog_Model_Resource_Product_Collection::isSpellchecked()

There was already an issue covering this problem: #47

Cause: In default Magento catalogsearch result collection isSpellchecked() is not available.

@mobilizer mobilizer changed the title FIX fallback to default Magento search if ES server is down FIX fallback to default Magento search if ES server is down (Issue #47) Oct 27, 2016
@mobilizer mobilizer mentioned this pull request Oct 27, 2016
@kirmorozov
Copy link

Yes, if you make elastic handle all the category and search traffic, there
is no point to have worse search relevance.
Just make sure elastic is running.

On Thu, Oct 27, 2016 at 9:31 PM, sam brown notifications@github.com wrote:

You are not suggesting we patch core magento files to fix this?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#88 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA9-iCVlqYsR37mgrl4DVdThECn3lKQLks5q4O30gaJpZM4Kiqgt
.


Kirill Morozov

http://www.magentocommerce.com/certification/directory/dev/37578/

email kir.morozov@gmail.com kir.morozov@gmail.com
US +1-424-27-27-050
RU +7-910-451-64-41
skype kir.morozov

@mobilizer
Copy link
Author

At least when using ElasticSearch just for search and autocomplete... handling this error and doing a fallback should be good practice!?
Is there any advantage in keeping this code line with an unhandled error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants