Remove additional queries looking for cached dimensions #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems this has been in the package since 2014 but I just noticed it today while trying to optimize server response times. I noticed that when I asked for with width and height of an image I was generating at least 1 extra query per image.
After reviewing the code it looks like a pretty easy win to disable the query to check if there is a dimension cached for a particular image which is being called regardless of the THUMBNAIL_CACHE_DIMENSIONS setting. This seems counter intuitive to me so I've added an if statement to check for the setting before running extra queries to find dimensions.