Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graphical hardware profile editor #2274

Merged
merged 70 commits into from
Mar 22, 2021

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Mar 21, 2021

I went with TK for this as it's bundled with python3. Basic but hopefully useful.

Enter make hwconfig-edit from project directory.

@lgtm-com
Copy link

lgtm-com bot commented Mar 21, 2021

This pull request introduces 2 alerts when merging c85a7aa into 2705310 - view on LGTM.com

new alerts:

  • 1 for Unused import
  • 1 for Nested loops with same variable

@slaff slaff added this to the 4.3.0 milestone Mar 22, 2021
@slaff
Copy link
Contributor

slaff commented Mar 22, 2021

@mikee47 The editor looks great! Would it be possible to add also delimiter/borders marking the end of a MB? For example delimite/border after 1MB, 2MB and so on.

@mikee47
Copy link
Contributor Author

mikee47 commented Mar 22, 2021

@slaff Adding markers, etc. isn't practical/possible with the treeview widget, but it was the simplest way to get a useable interface.

Further improvement could be made using a fully custom-drawn area, showing a more graphical map with some scaling, shading, etc. Something for the future...

@slaff
Copy link
Contributor

slaff commented Mar 22, 2021

Something for the future...

Ok, sounds fare. Are you ready with this PR or would like to add some more changes before I merge it?

@mikee47
Copy link
Contributor Author

mikee47 commented Mar 22, 2021

@slaff All done for now thanks.

@slaff slaff merged commit f42ae46 into SmingHub:develop Mar 22, 2021
@mikee47 mikee47 deleted the feature/hwconfig-editor branch March 22, 2021 10:03
@mikee47
Copy link
Contributor Author

mikee47 commented Mar 23, 2021

@slaff #2277 adds custom drawn map, is this the kind of thing you were after?

@slaff
Copy link
Contributor

slaff commented Mar 23, 2021

is this the kind of thing you were after?

I like the map. I was thinking about something simple but this is much better. If you haven't done so take a look for inspiration at qtparted or gparted in Linux. Their interface is powerful and easy to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants