MultiStream & StreamTransformer improvements #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
slaff
reviewed
Mar 24, 2021
| if(stream == nullptr) { | ||
| stream = getNextStream(); | ||
| if(stream == nullptr) { | ||
| if(!stream) { |
There was a problem hiding this comment.
@mikee47 Can you add tests for MultiStream and StreamTransformer?
Remove redundant method overrides Use `std::unique_ptr` to manage stream
mikee47
force-pushed
the
update/stream-improvements
branch
from
e25706b to
1abefe3
Compare
…eam / MultiStream
mikee47
force-pushed
the
update/stream-improvements
branch
from
1abefe3 to
3f210f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #2280 simplify and clarify StreamTransformer and MultiStream code