Pull Core/Network out into separate Component #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikee47
changed the title
mikee47
force-pushed
the
feature/disable-wifi
branch
2 times, most recently
from
bcdc245 to
2b7de24
Compare
mikee47
changed the title
slaff
reviewed
Apr 26, 2021
| @@ -12,7 +12,7 @@ | |||
|
|
|||
| #include "HttpRequestAuth.h" | |||
| #include "HttpRequest.h" | |||
| #include "Network/WebHelpers/base64.h" | |||
| #include <Data/WebHelpers/base64.h> | |||
There was a problem hiding this comment.
@mikee47 Please start an upgrade document for this release and add information that Network/WebHelpers/base64.h is now moved to Data/WebHelpers/base64.h.
There was a problem hiding this comment.
You happy with this change? We could leave the path as-is... or provide an alias so it doesn't break anything...
There was a problem hiding this comment.
or provide an alias so it doesn't break anything
I am ok with the change. It would be great if you can add the old header file pointing to the new one with a deprecation notice for smoother transition. Similar to what we have here: https://github.com/SmingHub/Sming/blob/d375ef74fd11f0796aa4483c0bdaacb4fb755655/Sming/SmingCore/SmingCore.h
mikee47
force-pushed
the
feature/disable-wifi
branch
from
183bb01 to
ad7a451
Compare
mikee47
force-pushed
the
feature/disable-wifi
branch
from
ad7a451 to
3826133
Compare
slaff
pushed a commit
that referenced
this pull request
Sep 27, 2021
The `DISABLE_WIFI` setting was introduced as an experimental feature for Esp8266 to reduce image sizes. This PR moves the networking support code into a separate library so it doesn't need to be built for these applications. This also improves built times for tools using the Host architecture, for example the LittleFS `fscopy` tool. The related code for each architecture has also been moved, including related units from `Platform`. Documentation has been revised and a few minor fixes included.
mikee47
added a commit
to mikee47/Sming
that referenced
this pull request
Oct 9, 2021
Should probably have been done in SmingHub#2316
mikee47
added a commit
to mikee47/Sming
that referenced
this pull request
Oct 9, 2021
Should probably have been done in SmingHub#2316
mikee47
added a commit
to mikee47/Sming
that referenced
this pull request
Oct 9, 2021
Should probably have been done in SmingHub#2316
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DISABLE_WIFIsetting was introduced as an experimental feature for Esp8266 to reduce image sizes. This PR moves the networking support code into a separate library so it doesn't need to be built for these applications.This also improves built times for tools using the Host architecture, for example the LittleFS
fscopytool.The related code for each architecture has also been moved, including related units from
Platform.Documentation has been revised and a few minor fixes included.