IFS attribute enumeration support #2318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikee47
changed the title
|
@mikee47 Please rebase this PR. |
mikee47
force-pushed
the
feature/ifs-enum-attributes
branch
from
a0c4ed5 to
6d94bcb
Compare
|
@slaff I've noticed some weird stuff going on with the hybrid tests - investigating |
|
@slaff OK found and fixed |
Fix `FileSystem::makedirs` - end of path could be a filename Fix duplicate files in hybrid readdir() - files not hidden as they should be
mikee47
force-pushed
the
feature/ifs-enum-attributes
branch
from
44258d8 to
a588550
Compare
mikee47
force-pushed
the
feature/ifs-enum-attributes
branch
from
b359949 to
d2d26a4
Compare
|
@mikee47 are you ready with this PR? |
|
@slaff All done thanks |
slaff
added
3.5 - Approved - Waiting for CI results
and removed
3 - Review
3.5 - Approved - Waiting for CI results
labels
slaff
pushed a commit
that referenced
this pull request
Sep 27, 2021
This PR implements a mechanism for efficiently enumerating file attributes. This is necessary for file copying, filtering, etc. **IFS** Add IFileSystem `fenumxattr` and `enumxattr` methods Add `OpenFlag::NoFollow` to support enumeration of mount point objects Add creationTime field to `IFileSystem::Info` Fix issue where `Directory` class size/count keeps increasing if `rewind()` used Revise test application to use LittleFS for Hybrid tests **LittleFS** Re-mount after format if appropriate Use ACL for root directory as default (consistent with FWFS behaviour) ACL stored in separate read/write entries; existing LittleFS partitions must be rebuilt. **Hybrid file system** Add check in mount() to ensure provided filesystem is writable In mount() copy root ACL from FWFS to use as default Ensure parent directories are created in open() method Repeat tests for both SPIFFS and LittleFS variants **Basic_IFS sample** Update to demonstrate enumeration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a mechanism for efficiently enumerating file attributes. This is necessary for file copying, filtering, etc.
IFS
Add IFileSystem
fenumxattrandenumxattrmethodsAdd
OpenFlag::NoFollowto support enumeration of mountpoint objectsAdd creationTime field to
IFileSystem::InfoFix issue where
Directoryclass size/count keeps increasing ifrewind()usedRevise test application to use LittleFS for Hybrid tests
LittleFS
Re-mount after format if appropriate
Use ACL for root directory as default (consistent with FWFS behaviour)
ACL stored in separate read/write entries; existing LittleFS partitions must be rebuilt.
Hybrid filesystem
Add check in mount() to ensure provided filesystem is writeable
In mount() copy root ACL from FWFS to use as default
Ensure parent direcotories are created in open() method
Repeat tests for both SPIFFS and LittleFS variants
Basic_IFS sample
Update to demonstrate enumeration