Added support for sending streams directly from TcpClient. #2341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaff
force-pushed
the
feature/tcpclient-send-stream
branch
from
0930a8c to
1385f91
Compare
slaff
force-pushed
the
feature/tcpclient-send-stream
branch
from
1385f91 to
048dcae
Compare
mikee47
reviewed
Jun 28, 2021
| setBuffer(new MemoryDataStream()); | ||
| if(buffer == nullptr) { | ||
| return false; | ||
| auto memoryStream = dynamic_cast<MemoryDataStream*>(stream); |
There was a problem hiding this comment.
dynamic_cast will require RTTI and, if enabled, would add overhead to every use of Stream so getStreamType() is preferable here.
There was a problem hiding this comment.
so getStreamType() is preferable here.
Thank you @mikee47. I will do exactly as suggested. Hope to find some time today to submit the new version of the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.