Add DISABLE_NETWORK and SDK_CUSTOM_CONFIG settings #2362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows DISABLE_WIFI to be used in conjunction with ethernet.
Project is created from a single default Settings are assembled from multiple files
mikee47
force-pushed
the
feature/disable-network
branch
from
344f694 to
db401ee
Compare
mikee47
changed the title
mikee47
force-pushed
the
feature/disable-network
branch
from
db401ee to
eed0271
Compare
|
Something else the esp32 builder doesn't do is rebuild the SDK components for debug/release automatically... That is, there needs to be a reconfigure step - though that would discard any customisations made via Can't see a simple way to get the IDF to use a different |
mikee47
commented
Sep 4, 2021
Comment on lines
385
to
386
| .PHONY: sdk-defconfig | ||
| sdk-defconfig: $(SDKCONFIG_H) ##Create default SDK config files |
There was a problem hiding this comment.
Don't think we need this, happens automatically.
mikee47
commented
Sep 4, 2021
| ##@SDK | ||
|
|
||
| SDK_PROJECT_PATH := $(COMPONENT_PATH)/project.$(ESP_VARIANT) | ||
| SDK_PROJECT_PATH := $(COMPONENT_PATH)/project/$(ESP_VARIANT) |
There was a problem hiding this comment.
Adding /$(BUILD_TYPE) to the end of this path fixes the issue switching between debug/release builds. We get a separate project instance for each.
slaff
pushed a commit
that referenced
this pull request
Sep 27, 2021
This PR adds the `DISABLE_NETWORK` setting to explicitly remove network support. When enabled, if performs much like `DISABLE_WIFI` except it now works for ESP32 as well. The behaviour of `DISABLE_WIFI` is now more logical, and can be used with ethernet. The ESP32 build process has been improved. PR #2358 added a separate project for each `ESP_VARIANT`. This is now created dynamically from a template along with the default configuration. The `SDK_CUSTOM_CONFIG` build variable has been added so ESP32 SDK settings may be configured on a per-project basis, if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
DISABLE_NETWORKsetting to explicitly remove network support. When enabled, if performs much likeDISABLE_WIFIexcept it now works for ESP32 as well. The behaviour ofDISABLE_WIFIis now more logical, and can be used with ethernet.The ESP32 build process has been improved. PR #2358 added a separate project for each
ESP_VARIANT. This is now created dynamically from a template along with the default configuration.The
SDK_CUSTOM_CONFIGbuild variable has been added so ESP32 SDK settings may be configured on a per-project basis, if necessary.