Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ArduinoJson6 serialisation bug and update from v6.13 to v6.15.2 #2363

Merged
merged 2 commits into from
Sep 11, 2021
Merged

Fix ArduinoJson6 serialisation bug and update from v6.13 to v6.15.2 #2363

merged 2 commits into from
Sep 11, 2021

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Sep 9, 2021 •
edited
Loading

Contains bugfix where serializing to String returns wrong length.
bblanchon/ArduinoJson@3aebef6

Example:

String s;
size_t length = Json::serialize(doc, s);
send(s.c_str(), length); ///< Problem: Returned length likely less than actual length
send(s); ///< OK, string is correct

Framework code not affected. Picked up by HostTests when running against bug-fixed version where returned length is correct.

Note: Releases after 6.15.2 require rework to FlashStringRefAdapter.

@mikee47
Update ArduinoJson6 from v6.13 to v6.15.2
5663bfe 
Contains bugfix where serializing to String returns wrong length.

Note: Later releases require rework to FlashStringRefAdapter
@mikee47
Windows CI build broken
b69ff64
@mikee47 mikee47 changed the title Update ArduinoJson6 from v6.13 to v6.15.2 Fix ArduinoJson6 bug and update from v6.13 to v6.15.2 Sep 11, 2021
@mikee47 mikee47 changed the title Fix ArduinoJson6 bug and update from v6.13 to v6.15.2 Fix ArduinoJson6 serialisation bug and update from v6.13 to v6.15.2 Sep 11, 2021
@mikee47 mikee47 added the Bug label Sep 11, 2021
@slaff slaff added this to the 4.4.0 milestone Sep 11, 2021
@slaff slaff merged commit 0626073 into SmingHub:develop Sep 11, 2021
@slaff slaff mentioned this pull request Sep 15, 2021
Closed
5 tasks
slaff pushed a commit that referenced this pull request Sep 27, 2021
@mikee47 @slaff
Fix ArduinoJson6 serialisation bug and update from v6.13 to v6.15.2 (#…
7571b91 
…2363)

* Update ArduinoJson6 from v6.13 to v6.15.2

Contains bugfix where serializing to String returns wrong length.

Note: Later releases require rework to FlashStringRefAdapter

* Windows CI build broken
@mikee47 mikee47 deleted the fix/arduino-json-6.15.2 branch January 15, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mikee47 @slaff