Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rationalise compiler flags and esp32 improvements #2388

Merged
merged 5 commits into from
Oct 11, 2021

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Oct 10, 2021

Fix build inconsistencies and move common settings from arch. into main Sming to reduce code duplication.

  • Rationalise compiler flags, add COMPONENT_CPPFLAGS
  • Add SMING_C_STD to debug vars
  • Get rid of obsolete Esp32 build settings (these related to pre-CMake builds)
  • Add Undef, UndefWrap, Wrap, DefSym linker function
  • Split Esp32 linker settings out. Use one file per esp32 component to simplify tracking settings and changes with IDF.
  • Simplify meminfo, rename as fwMeminfo.txt and remove old/saved
  • Wrap esp32 printf functions so they don't get pulled in from C library. Saves about 60K flash (and a little RAM).

Get rid of obsolete Esp32 build settings (these related to pre-CMake builds)
Add SMING_C_STD to debug vars
Add `Undef`, `UndefWrap`, `Wrap`, `DefSym` linker function
Use one file per esp32 component to simplify tracking settings and changes with IDF
@mikee47
Copy link
Contributor Author

mikee47 commented Oct 10, 2021

The codacy warning is about strlen - there are other instances of this in the framework. We could rewrite using strnlen instead but that increases code complexity and not sure it's warranted...

@slaff slaff added this to the 4.5.0 milestone Oct 11, 2021
@slaff slaff merged commit db49926 into SmingHub:develop Oct 11, 2021
@mikee47 mikee47 deleted the fix/build-revisions branch October 11, 2021 07:52
@slaff slaff mentioned this pull request Oct 15, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants