Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bit-length bugs in Esp32 SPIClass #2438

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Conversation

kmihaylov
Copy link
Contributor

These functions are added:

	spi_ll_set_dummy(&dev, 0);
	spi_ll_set_command_bitlen(&dev, 0);
	spi_ll_set_addr_bitlen(&dev, 0);

The PR should NOT be merged yet due SPI.read8() not working properly yet. #2437 (comment)

The text below is for my reference.

In Sming/Arch/Esp32/SPI.cpp the main `object` is the SPI device.
This object is spi_signal_conn_t (see esp-idf/components/soc/include/soc/spi_periph.h).
The hardware access is realised through the *hw member of this struct, that is of type
spi_dev_t (see esp-idf/components/soc/esp32/include/soc/spi_struct.h)
The Sming's SPI class uses the esp-idf's initialization functions declarations
in eps-idf/components/hal/esp32/include/hal/spi_ll.h

@mikee47 mikee47 changed the title Update SPIClass::begin() with additional default values Fix bit-length bugs in Esp32 SPIClass Dec 5, 2021
@mikee47 mikee47 changed the title Fix bit-length bugs in Esp32 SPIClass [WIP] Fix bit-length bugs in Esp32 SPIClass Dec 5, 2021
@mikee47
Copy link
Contributor

mikee47 commented Dec 5, 2021

@kmihaylov I've revised the title, just remove [WIP] when you're happy with the PR.

@kmihaylov kmihaylov changed the title [WIP] Fix bit-length bugs in Esp32 SPIClass Fix bit-length bugs in Esp32 SPIClass Dec 5, 2021
@slaff slaff added this to the 4.5.0 milestone Dec 6, 2021
@slaff slaff merged commit 9b3970c into SmingHub:develop Dec 6, 2021
@slaff slaff mentioned this pull request Dec 7, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants