Fix smg_uart_uninit() from blocking subsequent re-initialisation
#2560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handled in the driver.
mikee47
force-pushed
the
fix/uart-uninit
branch
from
2783b6d to
61b2cc7
Compare
Caller can check for errors.
slaff
pushed a commit
to slaff/Sming
that referenced
this pull request
Sep 30, 2022
…mingHub#2560) This PR fixes a bug in the Esp8266 and Host uart driver implementations of `smg_uart_uninit` which causes subsequent calls to `smg_uart_init_ex` to fail as it thinks the port is in use. This bug is exposed if a port is opened, closed and then re-opened: ``` Serial.begin(COM_SPEED_SERIAL); ... Serial.end(); // optional - begin() calls this internally anyway Serial.begin(9600); // fails ``` Also add a `bool` return value from `HardwareSerial::begin()` method so caller can check for errors.
slaff
added a commit
that referenced
this pull request
Oct 4, 2022
…2560) (#2561) This PR fixes a bug in the Esp8266 and Host uart driver implementations of `smg_uart_uninit` which causes subsequent calls to `smg_uart_init_ex` to fail as it thinks the port is in use. This bug is exposed if a port is opened, closed and then re-opened: ``` Serial.begin(COM_SPEED_SERIAL); ... Serial.end(); // optional - begin() calls this internally anyway Serial.begin(9600); // fails ``` Also add a `bool` return value from `HardwareSerial::begin()` method so caller can check for errors. Co-authored-by: Mike <mike@sillyhouse.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the Esp8266 and Host uart driver implementations of
smg_uart_uninitwhich causes subsequent calls tosmg_uart_init_exto fail as it thinks the port is in use.This bug is exposed if a port is opened, closed and then re-opened:
Also add a
boolreturn value fromHardwareSerial::begin()method so caller can check for errors.