Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor filesystem bugs #2563

Merged
merged 5 commits into from
Oct 1, 2022
Merged

Fix minor filesystem bugs #2563

merged 5 commits into from
Oct 1, 2022

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Sep 30, 2022

  • Fix return value from Spiffs fenumxattr(): Should return number of attributes read.
  • Fix LittleFS FileSystem::format() return value: int not bool
  • Remove (non-const) Device::partitions() method: Partition table is always accessed read-only
  • Remove Partition::getDevice() method: Could be used to bypass protections offered by partitioning API
  • Fix IFS::Stat::printTo() timestamp printing: Shows numeric (time_t) value instead of string

Should return number of attributes read.
Partition table is always accessed read-only
This could be used to bypass protections offered by partitioning API and allow code access to other areas of  a device.
Shows numeric (time_t) value instead of string
@slaff slaff added this to the 4.7.0 milestone Oct 1, 2022
@slaff slaff merged commit abbdbbf into SmingHub:develop Oct 1, 2022
@mikee47 mikee47 deleted the fix/filesystem branch October 1, 2022 09:55
@slaff slaff mentioned this pull request Nov 8, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants