-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve sample applications #2756
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow variable number of pins in list, web page updated dynamically
Includes static range check on value
Simplify code using LineBuffer Accept timestamp or HTTP date string
Didn't actually use RAM.
Also builds for other architectures than esp8266, so remove SOC restrictions.
mikee47
force-pushed
the
feature/improve-samples
branch
from
April 4, 2024 10:19
15d2700
to
cef7be9
Compare
Awesome work @mikee47 ! I will be more active next week and start reviewing the other PRs. Please, be patient with me as I am away from a proper computer at the moment :) |
@slaff No worries, we all have lives to lead! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all the main Sming samples to try and demonstrate best practice when coding Sming applications. Specifically:
SimpleTimer
is sufficient in most cases. This is both more efficient and avoids complication where compiler cannot distinguish between delegates and callback functions.startOnce()
method rather thanstart(false)
for(int i=0; i<list.count(); ++i) {...}
WIFI_SSID
andWIFI_PASSWORD
Serial
methods in preference todebug_x
where intent is not actually for debuggingif
statementsinit()
function at end of main application source fileSample-specific changes:
HttpServer_AJAX
so that GPIO numbers are consistent with web codeDateTime
.Print
stream support, updateBasic_Utility
sampleOther changes
jerryscript
library to latest. CI improvements and removes deprecation warnings.CommandProcessing
library