You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Got parameters reversed in FlashSring test code.
This isn't a problem for `memcmp_P` implementation in `Sming/Arch/Esp8266/Components/libc/src/oldlib/pgmspace.c` as it consider both parameters pointers to flash:
```
int memcmp_P(PGM_VOID_P a1, PGM_VOID_P b1, size_t len);
```
But the version in newlib (provided by esp-quick-toolchain) is:
```
int memcmp_P(const void* buf1, PGM_VOID_P buf2_P, size_t len);
```
This is the de-facto standard form used by Arduino, etc.
Expanded Program Memory Support
Aided support for program memory in the 'pgmspace.h' file across multiple platforms such as Esp32, Esp8266, Host, and Rp2040. This enhancement aids the software in handling and storing data more efficiently across a variety of hardware platforms.
Improved Function Interfaces
Updated the structure of various software functions to either expand capabilities or streamline behavior. This results in code that's easier to maintain and more flexible for future updates.
Enhanced Memory & String Manipulation Functions
The 'src' parameter has been replaced with 'src_P' in several memory and string manipulation functions, optimizing the way these functions handle information. This improves the efficiency of data management within the software while minimizing potential errors.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
slaff
added
3.5 - Approved - Waiting for CI results
and removed
3.5 - Approved - Waiting for CI results
labels
This PR improves performance of
FlashStringlibrary object iteration and indexing.