mprintf: reduce include overhead\nproper declare symbols with C linka… #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge\nfix crash when size is smaller than arg_size for %d %u\n fix padding for %d and %f\nfix buffer overflow for %d %f\n add vsnprintf equivalent \n add putch equivalent
slaff
commented
Nov 3, 2016
| // Author zitron: http://forum.arduino.cc/index.php?topic=37391#msg276209 | ||
| // modified by ADiea: remove dependencies strcat, floor, round; reorganize+speedup code | ||
| char *dtostrf(double floatVar, int minStringWidthIncDecimalPoint, int numDigitsAfterDecimal, char *outputBuffer) | ||
| extern char *dtostrf_p(double floatVar, int minStringWidthIncDecimalPoint, int numDigitsAfterDecimal, char *outputBuffer, char pad) |
There was a problem hiding this comment.
@ADiea why you have extern here?!
There was a problem hiding this comment.
Hmm agree should be removed, no idea what was on my mind
slaff
commented
Nov 3, 2016
| @@ -7,7 +7,8 @@ Descr: embedded very simple version of printf with float support | |||
| */ | |||
|
|
|||
| #include <stdarg.h> | |||
| #include "../../SmingCore/SmingCore.h" | |||
| //#include "../../SmingCore/SmingCore.h" | |||
There was a problem hiding this comment.
@ADiea If you want to use only osapi.h then please remove the commented include above.
There was a problem hiding this comment.
ok, good to see activity on sming again!
|
Is it ready? |
|
I'm very like this PR corrections and think it should be merged as soon as possible. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ge\nfix crash when size is smaller than arg_size for %d %u\n fix padding for %d and %f\nfix buffer overflow for %d %f\n add vsnprintf equivalent \n add putch equivalent
Rebase of #748