Require an explicit unlock call in SessionLock #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The entire reason unlock_and_destroy is distinct from destroy is to avoid accidental unlock operations. The current SCTK implementation carefully undoes this work by unlocking on drop, even if that drop is due to a panic or careless drop of the lock object. Add an explicit unlock call so that screen lockers can indicate when they intend to unlock (generally after some kind of authentication has happened).
wash2
approved these changes
Feb 29, 2024
|
The ideal solution would be to have some kind of "linear typing" which would prevent implicit dropping except though panics. But yeah, this is probably correct without any better solution. This is a breaking API change for any client using session lock. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The entire reason unlock_and_destroy is distinct from destroy is to avoid accidental unlock operations. The current SCTK implementation carefully undoes this work by unlocking on drop, even if that drop is due to a panic or careless drop of the lock object.
Add an explicit unlock call so that screen lockers can indicate when they intend to unlock (generally after some kind of authentication has happened).