XWayland keyboard grab protocol

[ids1024]

No description provided.

[Drakulix]

Looks good!

[ids1024]

Would it be better for Smithay to call set_grab here, instead of requiring a grab handler method? That's what is done for input-method. Is there any reason a compositor would want to do something other than just setting the grab like the Anvil implementation here?

Or it could provide a default implementation for the grab method, at least.

[Drakulix]

Would it be better for Smithay to call set_grab here, instead of requiring a grab handler method? That's what is done for input-method. Is there any reason a compositor would want to do something other than just setting the grab like the Anvil implementation here?

Or it could provide a default implementation for the grab method, at least.

Default implementation is fine, but given the protocol explicitly does not guarantee the grab to be set and suggest compositors might even show indicators for keys being captured, I say this should be compositor policy.

[codecov-commenter]

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (bb25baf) 24.01% compared to head (fe9beab) 24.01%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1093      +/-   ##
==========================================
- Coverage   24.01%   24.01%   -0.01%     
==========================================
  Files         140      140              
  Lines       21589    21591       +2     
==========================================
- Hits         5185     5184       -1     
- Misses      16404    16407       +3     

Flag	Coverage Δ
wlcs-buffer	21.03% <100.00%> (+<0.01%)	⬆️
wlcs-core	20.66% <100.00%> (+<0.01%)	⬆️
wlcs-output	8.46% <100.00%> (+<0.01%)	⬆️
wlcs-pointer-input	22.71% <100.00%> (+0.06%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
anvil/src/state.rs	38.46% <100.00%> (+0.32%)	⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Drakulix]

LGTM