Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this a run of
cargo fix --edition
for all our feature combinations + actually settingedition = "2018"
for our crates + adding therust_2018_idioms
lint to our warnings + fixing those + formatting.That lint is currently not doing very much. It is supposed to fix "old-style" code and is what is running, when using
cargo fix --edition-idioms
. But right now that only seems to include usage of thedyn
keyword for trait objects, and explicit anonymous lifetimes as well as uselessextern crate
definitions.A lot more changes are recommend, like importing macros instead of using
macro_use
. But especially for macros this requires a hack to support all editions for libraries in the moment (e.g.) and I am not sure, if all our dependencies are prepared for that right now.So instead lets go with the pace of ecosystem and fix up new lints as they popup in the
rust_2018_idioms
group in the next rust updates, instead of trying the whole code base now.Depends on #122 & #123 (as everything needed to be compiling to run
cargo fix
, which is how I noticed those errors and decided to put them into our travis build).