Skip to content

Update memoffset to 0.9 #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2023
Merged

Update memoffset to 0.9 #626

merged 1 commit into from
May 22, 2023

Conversation

est31
Copy link
Contributor

@est31 est31 commented May 21, 2023

Updates memoffset to version 0.9

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.98 ⚠️

Comparison is base (7bb545d) 74.56% compared to head (ccb716a) 73.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #626      +/-   ##
==========================================
- Coverage   74.56%   73.58%   -0.98%     
==========================================
  Files          53       47       -6     
  Lines        7648     7637      -11     
==========================================
- Hits         5703     5620      -83     
- Misses       1945     2017      +72     
Flag Coverage Δ
main 58.98% <ø> (-0.06%) ⬇️
test-- 78.34% <ø> (-0.54%) ⬇️
test--server_system 61.63% <ø> (-0.45%) ⬇️
test-client_system- 69.36% <ø> (-0.58%) ⬇️
test-client_system-server_system 51.62% <ø> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@elinorbgr
Copy link
Member

Thanks!

@elinorbgr elinorbgr merged commit c8b02e9 into Smithay:master May 22, 2023
@est31
Copy link
Contributor Author

est31 commented Jun 2, 2023

(coming from rust-lang/rust#111839) I ran:

cargo +nightly test --features memoffset/unstable_offset_of --no-fail-fast

And it showed the same tests to fail that showed up when you drop the --features flag:

---- client_receive_generic_error stdout ----
Protocol error 42 on object wl_compositor@3: 
Protocol error 42 on object wl_compositor@3: 
thread 'client_receive_generic_error' panicked at 'assertion failed: `(left == right)`
  left: `""`,
 right: `"I don't like you!"`', wayland-tests/tests/protocol_errors.rs:56:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

[...]

---- creation_destruction_race stdout ----
Io error: Invalid argument (os error 22)
Io error: Invalid argument (os error 22)
thread 'creation_destruction_race' panicked at 'called `Result::unwrap()` on an `Err` value: Io(Os { code: 22, kind: InvalidInput, message: "Invalid argument" })', wayland-tests/tests/server_created_object.rs:276:79
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

[...]

error: 2 targets failed:
    `-p wayland-tests --test protocol_errors`
    `-p wayland-tests --test server_created_object`

@elinorbgr
Copy link
Member

Yeah, wayland-test tests should not be ran as part of the whole workspace tests, as it causes some inconsistency in the cargo features. That's why the CI runs the workspace tests with --exclude wayland-test, and then the wayland-test tests by themselves afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants