Remove a pointless allocation #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
None of the failures look related. |
|
Yeah, looks like #772 has fixes for the CI errors here. I thought there was a reason this used a vec... and it looks like I was right, but this has been fixed in Rustix: bytecodealliance/rustix#889. (Which I now remember seeing.) I guess we should update the |
|
Bumping rustix sounds good and I'll wait for the other PR. |
|
That PR is merged. If CI passes after rebasing and updating the |
The stack size is 152 bytes which is teeny.
|
All green |
ids1024
approved these changes
Dec 23, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stack size is 152 bytes which is teeny.