Support multiple (possibly offline) audio contexts #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They will now check using multiple (possibly offline) audio contexts, and include tools in the page for testing the audio output. I've reverted the test dsp to a simple noise generator to get some audio to test, but this harness will evolve over time to test the faust output and types more thoroughly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some ill-advised caching code for the processor files, which was preventing the use of one
.dspmodule with multipleAudioContexts. Classic case of premature optimization 😅It also expands the test cases to include instantiation with multiple contexts, rendering of an offline context, and tools for quality assurance on the output audio.
Finally, I added some safeguards to the publishing process and minimized the files to be included in the NPM package.
Resolves #5