Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jail problems... #1902

Open
AjaxTheGod opened this issue Feb 3, 2024 · 7 comments
Open

Jail problems... #1902

AjaxTheGod opened this issue Feb 3, 2024 · 7 comments
Labels
🐛 bug Something isn't working

Comments

@AjaxTheGod
Copy link

What version of Node.js are you using?

1.78.5

What operating system are you using?

Debian12

What version of SnailyCAD are you currently using?

1.79.0

Describe the Bug

Citizens can't be released from jail and aren't released automatically.

Even if they get bailed/released by an admin or their time has expired they still show on the jail roster

ADDITIONALLY,
When new citizens are being arrested they are not showing up on the jail, even when "Show Active Only" is selected. (yes, they should still be in jail, they should not have been released)

Expected Behavior

  • Ability to jail citizens
  • Ability to see only citizens actively incarcerated
  • Ability to release citizens from jail effectively

To Reproduce

Just have ~ 10-15 people in your jail for various sentences (my jail terms are set by hours in CAD). You will almost certainly begin to notice the issues mentioned.

@casperiv0 casperiv0 removed their assignment Feb 3, 2024
@13LuckyBack
Copy link

13LuckyBack commented Feb 4, 2024

Hey @AjaxTheGod may i ask what you mean? If you can send screenshot's with it that would help me out understand you beter.

@Legacy-TacticalGamingInteractive
Copy link

Legacy-TacticalGamingInteractive commented Feb 5, 2024

I was just going to comment on this.
image

It would be nice if we have this feature but for Jailed people. So we can see who is still supposed to be in Jail.
Another feature would be nice to Prune/Mass Release people in jail. We have literally 60 pages of it and no way to clean it up unless maybe going into the database?

@Infiniti-Development Infiniti-Development self-assigned this Feb 9, 2024
@Infiniti-Development
Copy link
Contributor

Hey @AjaxTheGod If you can send screenshot's with it that would help me out understand you beter.

@WhitigolProd
Copy link
Collaborator

@AjaxTheGod I am unable to reproduce this issue. Can you please provide me with some additional information, possibly error logs, etc?

Thanks!

@WhitigolProd
Copy link
Collaborator

Another feature would be nice to Prune/Mass Release people in jail. We have literally 60 pages of it and no way to clean it up unless maybe going into the database?

Each citizen can be "released" under a different condition, either bail posted, or time out. How would you propose a mass deletion be implemented? Should they all be released under the "Time Out" condition?

cc @Legacy-TacticalGamingInteractive

WhitigolProd added a commit that referenced this issue Feb 13, 2024
This adds a warning banner to the citizen search modal if the citizen is
currently arrested. This can be useful for citizens who are not supposed
to be released, jail breaks, etc. This was suggested in
#1902 (comment)

### New Translation Values

- [x] Added `isArrested` translation value to all `.json` translation
files.
- [x] `.json` files are formatted: `pnpm format`
- [x] Translations are correct
@WhitigolProd
Copy link
Collaborator

I was just going to comment on this. image

It would be nice if we have this feature but for Jailed people. So we can see who is still supposed to be in Jail.

Added in b37bde7

@Infiniti-Development Infiniti-Development removed their assignment Feb 15, 2024
@bartusek27
Copy link
Contributor

Seems that there is a problem in the API - after the update (can't tell exact version), we have noticed that release (automatic and manual) is not working - throws citizen_not_found error. Discussed in https://discord.com/channels/792479048457912360/1212242677806923807

@Infiniti-Development Infiniti-Development added the 🐛 bug Something isn't working label May 31, 2024
@casperiv0 casperiv0 mentioned this issue Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
Status: 🆕 New
Development

No branches or pull requests

7 participants