Refactor Docker Stack #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Dockerfile: Set of instructions for creating development and production image * entrypoint.sh: This file override the default entrypoint of the image. Install npm dependencies and run npm script based of enviroment
* Add message for app running mode (ex. development, production) * Add build script to production mode
* Add Builder step * Add Development step * Add Production step
* dev.compose.yaml - For development only use * prod.compose.yaml - For production only use
In current structure of docker if not present, the app is not starting because missing dependencies
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: nodemon@3.0.2 |
casperiv0
requested changes
Jan 1, 2024
- Add .data and .dev-data in .gitignore file - Add .data and .dev-data in .dockerignore file
- Re-add ts-node in dev dependencies - Update the dev script to use ts-node with node --watch flag
- Add .dev-data folder as volume - Remove docker volume
- Add .dev-data folder as volume - Remove docker volume - Uncomment ports
- Add docker:clean script - Update docker-dev:start script - Update docker-prod:start script - Update docker-dev:build script - Update docker-prod:build script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I update the development and production docker stack with security and minimalism in mind.
I'm open for advice and comments.
P.S.: Happy new year, happy 2024 🎉