Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: User-defined dataset driven tests #43

Closed
wants to merge 37 commits into from

Conversation

Snaipe
Copy link
Owner

@Snaipe Snaipe commented Sep 17, 2015

From the discussion at #40, a use-case has come to light:

[...] to implement parameterized tests, that would iterate over a user-generated dataset rather than the cartesian product of many datasets.

Also, this will run a separate test for each member of dataset and hence yield better result stats.

e.g. current approach is to enumerate over TheoryDataSet placeholder data array, which results in:

[====] Synthesis: Tested: 1 | Passing: 0 | Failing: 1 | Crashing: 0

for 1276 data items tested out of which (for example) only 26 are failing.

With ParameterizedTest feature, we expect to get:

[====] Synthesis: Tested: 1276 | Passing: 1250 | Failing: 26 | Crashing: 0

@Snaipe
Copy link
Owner

Snaipe commented Sep 17, 2015

It seems the hub utility chocked on the number of commits included for the merge, the pull request has been recreated at #44.

@Snaipe Snaipe closed this Sep 17, 2015
@Snaipe Snaipe mentioned this pull request Sep 17, 2015
@am11
Copy link
Contributor Author

am11 commented Sep 17, 2015

Today is a mystery day. This is my first day to learn that it is possible to convert an existing issue to a pull request on GitHub. "How?" is still a mystery. It took me sometime to confirm that I indeed opened an issue, not a PR. 😄

@Snaipe
Copy link
Owner

Snaipe commented Sep 17, 2015

@am11 you can convert any issue to a pull request with the hub CLI utility:

hub pull-request -b <base branch> -i <issue number>

@am11
Copy link
Contributor Author

am11 commented Sep 17, 2015

Excellent! Will give it a try. Thanks for sharing git + hub = GitHub. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants